Skip to content

Hermite kyle davide#44

Merged
kylebeggs merged 27 commits intohermite-kylefrom
hermite-kyle-davide
Oct 28, 2025
Merged

Hermite kyle davide#44
kylebeggs merged 27 commits intohermite-kylefrom
hermite-kyle-davide

Conversation

@Davide-Miotti
Copy link
Member

No description provided.

@claude
Copy link

claude bot commented Sep 5, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 88.38710% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/operators/directional.jl 0.00% 22 Missing ⚠️
src/operators/monomial/monomial.jl 20.00% 8 Missing ⚠️
src/solve_hermite.jl 95.34% 4 Missing ⚠️
src/solve_utils.jl 98.57% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/RadialBasisFunctions.jl 100.00% <ø> (ø)
src/boundary_types.jl 100.00% <100.00%> (ø)
src/interpolation.jl 100.00% <100.00%> (ø)
src/operators/custom.jl 100.00% <ø> (ø)
src/operators/gradient.jl 100.00% <100.00%> (ø)
src/operators/laplacian.jl 100.00% <100.00%> (ø)
src/operators/operators.jl 100.00% <100.00%> (ø)
src/operators/partial.jl 100.00% <100.00%> (ø)
src/solve.jl 100.00% <100.00%> (ø)
src/solve_utils.jl 98.61% <98.57%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@Davide-Miotti Davide-Miotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look very good to me, there will always be room for further optimization but this is already a good point.. I tried to removed from solve_hermite.jl the duplicated code from solve.jl and it still seems to work, I'll commit that one

@claude
Copy link

claude bot commented Sep 14, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 14, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 21, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] reported by reviewdog 🐶

result = RBF.stencil_type(is_boundary, boundary_conditions, 2, neighbors, global_to_boundary)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

result = RBF.stencil_type(is_boundary, boundary_conditions, 4, neighbors, global_to_boundary)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

result = RBF.stencil_type(is_boundary, boundary_conditions, 5, neighbors, global_to_boundary)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

result = RBF.stencil_type(is_boundary, boundary_conditions, 1, neighbors, global_to_boundary)


[JuliaFormatter] reported by reviewdog 🐶

@claude
Copy link

claude bot commented Sep 21, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 21, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 21, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@Davide-Miotti
Copy link
Member Author

all tests passed, ready to merge

@kylebeggs kylebeggs merged commit 59bf7bf into hermite-kyle Oct 28, 2025
16 checks passed
@kylebeggs kylebeggs deleted the hermite-kyle-davide branch October 30, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants