Include last data point in linear system solve for interpolating weights#46
Merged
kylebeggs merged 3 commits intoJuliaMeshless:mainfrom Oct 23, 2025
Merged
Include last data point in linear system solve for interpolating weights#46kylebeggs merged 3 commits intoJuliaMeshless:mainfrom
kylebeggs merged 3 commits intoJuliaMeshless:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
|
@cgeoga thanks so much for this PR! I added a test and refactored the line to use more idiomatic Julia. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slightly funny one-char PR. But on the main branch right now, the linear system that is set up to compute the weights for the interpolating equations effectively treats the last function value (
y[end]) as being zero instead of using the value, which can create some funny incorrect answers downstream.