Skip to content

Include last data point in linear system solve for interpolating weights#46

Merged
kylebeggs merged 3 commits intoJuliaMeshless:mainfrom
cgeoga:main
Oct 23, 2025
Merged

Include last data point in linear system solve for interpolating weights#46
kylebeggs merged 3 commits intoJuliaMeshless:mainfrom
cgeoga:main

Conversation

@cgeoga
Copy link
Contributor

@cgeoga cgeoga commented Oct 22, 2025

A slightly funny one-char PR. But on the main branch right now, the linear system that is set up to compute the weights for the interpolating equations effectively treats the last function value (y[end]) as being zero instead of using the value, which can create some funny incorrect answers downstream.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/interpolation.jl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kylebeggs
Copy link
Member

@cgeoga thanks so much for this PR! I added a test and refactored the line to use more idiomatic Julia.

@kylebeggs kylebeggs merged commit e0330a3 into JuliaMeshless:main Oct 23, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants