Conversation
Thread `device` kwarg through all operator constructors and weight- building paths. Add Adapt.adapt_structure for RadialBasisOperator and Interpolator to enable GPU array conversion. Introduce _to_cpu helper for KDTree compatibility, _solve_system! dispatch for symmetric vs generic solvers, and an informative error when GPU stencil solve is attempted. Clean up verbose argument lists in execution.jl.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
- Widen batch call from Vector to AbstractVector and use map for GPU parallelism - Add test that non-CPU device throws ArgumentError - Add breadcrumb comment in _construct_sparse for future GPU sparse conversion (#88)
On Julia 1.10/1.11, _construct_sparse return type is inferred as a Union, causing AugmentedRuleReturnError. Explicitly parameterize AugmentedReturn with the primal type from the Enzyme return annotation so type parameters match exactly.
…edOperator Replace `out[:, d] = op.weights[d] * x` with `mul!(view(...), ...)` in three _eval_op methods, matching the pattern already used in the in-place variants. Also use `similar` instead of explicit Array constructors for GPU-safe allocation.
Combine pre-computed weights directly instead of rebuilding from scratch via the unified constructor, which always produces CPU SparseMatrixCSC. This prevents scalar indexing errors when calling combined operators on CuArrays.
Avoids errors when collections are empty or on GPU arrays where first() may not be efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add Adapt, device kwarg