Skip to content

[libpolymake_julia] rebuild with new libjulia for older Oscar versions#11658

Merged
benlorenz merged 1 commit intoJuliaPackaging:masterfrom
benlorenz:bl/lpm0135
Jul 14, 2025
Merged

[libpolymake_julia] rebuild with new libjulia for older Oscar versions#11658
benlorenz merged 1 commit intoJuliaPackaging:masterfrom
benlorenz:bl/lpm0135

Conversation

@benlorenz
Copy link
Copy Markdown
Contributor

Since #11607 will be for future Oscar versions only, this rebuild would help get julia 1.12 working with Oscar 1.4.

cc: @fingolfin @lgoettgens

@lgoettgens
Copy link
Copy Markdown
Contributor

You don't need to bump the version here as you just change a build dependency, see #11553 and #11561.
If you don't change the version numbers, you don't need to do another Polymake.jl release just to update the provided jll version.

@benlorenz
Copy link
Copy Markdown
Contributor Author

You don't need to bump the version here as you just change a build dependency, see #11553 and #11561. If you don't change the version numbers, you don't need to do another Polymake.jl release just to update the provided jll version.

The compat in Polymake.jl allows a patch level bump without a new release.
With the version bumps it is slightly cleaner as it makes sure libpolymake_julia and polymake_oscarnumber are matching, and disallows a mix between an updated and an old version.

@lgoettgens
Copy link
Copy Markdown
Contributor

You don't need to bump the version here as you just change a build dependency, see #11553 and #11561. If you don't change the version numbers, you don't need to do another Polymake.jl release just to update the provided jll version.

The compat in Polymake.jl allows a patch level bump without a new release. With the version bumps it is slightly cleaner as it makes sure libpolymake_julia and polymake_oscarnumber are matching, and disallows a mix between an updated and an old version.

In my memory, polymake_oscarnumber_jll was specified with a =version qualifier. But that's not the case, so just ignore everything I wrote

@benlorenz benlorenz merged commit bd4920a into JuliaPackaging:master Jul 14, 2025
14 checks passed
@benlorenz benlorenz deleted the bl/lpm0135 branch July 15, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants