You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You don't need to bump the version here as you just change a build dependency, see #11553 and #11561.
If you don't change the version numbers, you don't need to do another Polymake.jl release just to update the provided jll version.
You don't need to bump the version here as you just change a build dependency, see #11553 and #11561. If you don't change the version numbers, you don't need to do another Polymake.jl release just to update the provided jll version.
The compat in Polymake.jl allows a patch level bump without a new release.
With the version bumps it is slightly cleaner as it makes sure libpolymake_julia and polymake_oscarnumber are matching, and disallows a mix between an updated and an old version.
You don't need to bump the version here as you just change a build dependency, see #11553 and #11561. If you don't change the version numbers, you don't need to do another Polymake.jl release just to update the provided jll version.
The compat in Polymake.jl allows a patch level bump without a new release. With the version bumps it is slightly cleaner as it makes sure libpolymake_julia and polymake_oscarnumber are matching, and disallows a mix between an updated and an old version.
In my memory, polymake_oscarnumber_jll was specified with a =version qualifier. But that's not the case, so just ignore everything I wrote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #11607 will be for future Oscar versions only, this rebuild would help get julia 1.12 working with Oscar 1.4.
cc: @fingolfin @lgoettgens