Skip to content

Add PWPoly#13304

Open
chkat wants to merge 1 commit intoJuliaPackaging:masterfrom
chkat:add-pwpoly
Open

Add PWPoly#13304
chkat wants to merge 1 commit intoJuliaPackaging:masterfrom
chkat:add-pwpoly

Conversation

@chkat
Copy link
Copy Markdown

@chkat chkat commented Mar 16, 2026

Add PWPoly - C library for complex polynomial root finding and multipoint evaluation.

Upstream: https://gitlab.inria.fr/gamble/pwpoly
License: LGPL

Comment on lines +11 to +13
# FLINT 2.8.5
GitSource("https://github.com/flintlib/flint2.git",
"25aad90b890e2cb4a3a949f6311f0713449bb125"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the JLL version of FLINT (FLINT_jll) and add it as a Dependency instead of building another version here.

Just a note, FLINT now uses a special versioning scheme where the parts are multiplied by 100 - e.g., 2.8.5 has version 200.800.500 in Julia. You can see all the versions available here: https://github.com/JuliaRegistries/General/blob/master/jll/F/FLINT_jll/Versions.toml.

Comment on lines +15 to +17
# Arb 2.22.1
GitSource("https://github.com/fredrik-johansson/arb.git",
"b401d7cc3433f34de9f4c6cd518dfaf1bfac7484"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - please use a JLL version of this. If the current version is too old, then it is better to update the Arb_jll to the version instead of building here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arb is no longer maintained on its own, but instead has been merged into FLINT v3. But according to https://github.com/JuliaRegistries/General/blob/master/jll/A/Arb_jll/Versions.toml, there are jlls for Arb v2.22.0 (200.2200.0) and v2.23.0 (200.2300.0).

Comment on lines +105 to +106
Dependency("GMP_jll"),
Dependency("MPFR_jll"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify compat bounds on these packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants