remove eltype interface-piracy#385
Merged
rayegun merged 1 commit intoJuliaSparse:mainfrom May 3, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 93.86% 93.86% -0.01%
==========================================
Files 12 12
Lines 7487 7484 -3
==========================================
- Hits 7028 7025 -3
Misses 459 459
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Test failures are the same as seen in #380, i.e., unrelated. |
rayegun
approved these changes
May 3, 2023
Member
rayegun
left a comment
There was a problem hiding this comment.
Fine, I'm not aware of any reason to keep these if they're all subtypes of AbstractArray
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These specializations are unnecessary since the
eltype(Type{AbstractArray{T}}) where Tfallback already ensures this behavior; i.e., the interface of the supertype already provides this.Removing this was motivated by a discussion in the ttfx Slack channel where vtjnash indicated that these types of superfluous interface-extensions could be considered a form of piracy.
Details
This addresses the following entry from a
@snooprreport: