add logabstanh function#104
Merged
tpapp merged 14 commits intoJuliaStats:masterfrom Aug 18, 2025
nsajko:feature_logabstanh
Merged
add logabstanh function#104tpapp merged 14 commits intoJuliaStats:masterfrom nsajko:feature_logabstanh
logabstanh function#104tpapp merged 14 commits intoJuliaStats:masterfrom
nsajko:feature_logabstanh
Conversation
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
They can be added back in a future PR as an optimization.
Contributor
Author
My reasoning is that these are merely optimizations, so they can be considered separately in a future PR. |
tpapp
approved these changes
Aug 18, 2025
Collaborator
tpapp
left a comment
tpapp
left a comment
There was a problem hiding this comment.
LGTM, thanks! I agree that the specific optimizations can be left for future work.
devmotion
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revive PR #86, but without the
Float32-specific implementation and without theFloat64-specific implementation.Closes #86