Conversation
This was referenced Sep 21, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
andreasnoack
approved these changes
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this PR fixes tests on all Julia versions.
The main problem on the master branch is that the return type of
/(::AbstractVector, ::AbstractPDMat)is not consistent anymore with the behaviour in LinearAlgebra >= 1.9. I was not able to track down the exact commit where this behaviour changed but since the first alpha release of 1.9 LinearAlgebra returns a vector in these cases whereas in Julia <= 1.8.5 a matrix was returned.The second problem were the BandedMatrices tests; they were failing due to some upstream problems (only the computations of the reference values were affected it seems) but this could be fixed by simplifying the calculation of the ground truth values.