Skip to content

Enhance build process#38

Merged
stevengj merged 1 commit intoJuliaStrings:masterfrom
jlec:jlec-master
May 30, 2015
Merged

Enhance build process#38
stevengj merged 1 commit intoJuliaStrings:masterfrom
jlec:jlec-master

Conversation

@jlec
Copy link
Copy Markdown
Contributor

@jlec jlec commented May 29, 2015

  • Allow optimization flgas in CFLAGS to be overwritten
  • Use Uppercase CC and CFLAGS
  • Create all soname symlinks

Signed-off-by: Justin Lecher jlec@gentoo.org

* Allow optimization flgas in CFLAGS to be overwritten
* Use Uppercase CC and CFLAGS
* Create all soname symlinks

Signed-off-by: Justin Lecher <jlec@gentoo.org>
@jlec jlec mentioned this pull request May 29, 2015
Comment thread Makefile
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, why is this needed? AR=ar can be overridden by make AR=.... already. Is it so that environment variables can override?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in case your environment has everything set, you just need to run make. Especially when doing crosscompilation it is important not to call e.g. ar but the target platform specific version.

stevengj added a commit that referenced this pull request May 30, 2015
@stevengj stevengj merged commit 1f21f3c into JuliaStrings:master May 30, 2015
tkelman added a commit that referenced this pull request May 30, 2015
#35 and #40 added new tests that #38 did not take into account

this is one case where it would be good if Travis re-tested the PR
after new commits get pushed to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants