Enable to follow symbolic link directories when dataset upload#246
Open
i-aki-y wants to merge 5 commits intoKaggle:mainfrom
Open
Enable to follow symbolic link directories when dataset upload#246i-aki-y wants to merge 5 commits intoKaggle:mainfrom
i-aki-y wants to merge 5 commits intoKaggle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
useful feature to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I want to allow following symbolic link directories when uploading a dataset.
The current implementation looks to silently ignore symbolic link directories when upload a dataset because of
os.walk's default behavior.This can confuse the user. In particular, it is possible that missing only a portion of the dataset will cause a slight mismatch in the model's performance between trained by the original and uploaded datasets. Identifying the cause of such problems can be difficult.
So I want to add a flag that allows following symbolic link directories and add some log messages that inform for user when some directories are skipped.
related issue? #119
I would appreciate it if you could review this.