Add react exhaustive dependencies linter rule #657
+1,765
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BitwiseAndrea
changed the title
chriscerie
requested changes
Nov 28, 2025
Collaborator
chriscerie
left a comment
chriscerie
left a comment
There was a problem hiding this comment.
Thanks! Need changelog. It would be great to run this against the tests from #548 to gain visibility into the drift between these impls
| @@ -0,0 +1,32 @@ | |||
| error[roblox_react_exhaustive_deps]: React Hook useEffect has unnecessary dependency: props.value | |||
Collaborator
There was a problem hiding this comment.
Super nit: we use lowercase in these messages
| 11 │ end, { props.value }) | ||
| │ ^^^^^^^^^^^^^^^ | ||
| │ | ||
| = Remove 'props.value' from the dependency array |
Collaborator
There was a problem hiding this comment.
Same thing and we prepend help: here
Co-authored-by: Chris Chang <[email protected]>
…om/BitwiseAndrea/selene into feature/react-missing-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
Upstream
https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/src/rules/ExhaustiveDeps.ts
https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js