Merged
Conversation
So next run will benefit from Emscripten cache. Just stop it.
It was getting its own unique value instead of being the same as LDR.
Emscripten 3.0.9 was removing this method which is used in the binding.
Emscripten 3.0.8+ require that this policy be specified.
* Make ASTC encoder pick appropriate mode when input is DEFAULT. * Document the modes in ktx.h.
richgel999
pushed a commit
to BinomialLLC/KTX-Software-Binomial-Fork
that referenced
this pull request
Mar 9, 2026
Includes the following fixes to work with Emscripten 4.0.9: - Install sdl2 with `embuilder` as SDL2's config file is no longer installed in SYSROOT without this explicit step. - Explicitly allow_raw_pointers() when returning TranscodedImage. Emscripten 4.0.8+ require that this policy be specified. - Add HEAP8 method to EXPORTED_RUNTIME_METHODS. Emscripten 4.0.9 removes this method, which is used in the binding. Fix `scripts/build_wasm_docker.sh` to not remove the emscripten Docker container when done so the next run will benefit from the Emscripten cache. Removal can be requested with `-r`. Fix handling of the KTX_PACK_ASTC_ENCODER_MODE_DEFAULT. When passed in params.mode to ktxTexture2_EncodeAstcEx this value triggered an assert. The function now picks a mode appropriate to the bit-depth of the input texture. Document this handling in ktx.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following fixes to work with Emscripten 4.0.9:
embuilderas SDL2's config file is no longer installed in SYSROOT without this explicit step.Fixes
scripts/build_wasm_docker.shto not remove the emscripten Docker container when done so the next run will benefit from the Emscripten cache. Removal can be requested with-r.Fixes the KTX_PACK_ASTC_ENCODER_MODE_DEFAULT value which was getting its own unique enumerator value instead of being the same value as LDR.