Merged
Conversation
Working except for swipe gestures.
the same as SDL2. We don't need to blend with the underlying page. Write 1.0f to fragcolor.a in the shaders instead of the texture's transparency. Previous behaviour was a bug that had no visible effect due to having no alpha channel.
They should not be freed.
Add event logging.
Make detection of zoomin vs. spreading more robust and process finger up events to ensure recogniztion of end of gesture.
It now rotates around the perceived z axis rather than the real one.
Add logging and asserts for testing.
Safety checking prior to cleaning up the code.
Revert to using iAngle.
Fix print of finger ids.
richgel999
pushed a commit
to BinomialLLC/KTX-Software-Binomial-Fork
that referenced
this pull request
Mar 9, 2026
Related fixes: - appfwSDL target now requires c++17. - Fixes long standing issue of spurious multi-gesture events in load test apps. - Change cubemap tests so rotation gesture rotates around the perceived z-axis. - Add swipe up-down gesture to change model in cube map tests. Coming along for the ride: - Fix: remove files from .gitattributes that don't contain attributes. - Fix: install nuget & mono on CI runners (macOS 15+ ) from which they have been removed. - Fix: only issue "unittests build disabled" message if KTX_FEATURE_TESTS is ON. - Fix: don't try to install vkloadtests dependencies on Windows when only building gl3loadtests. - Fix: set the app icon on the vkloadtests window on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related fixes:
Coming along for the ride: