Skip to content

Support array and 3d textures.#468

Merged
MarkCallow merged 3 commits intomasterfrom
tuket-support_array_textures
Aug 15, 2021
Merged

Support array and 3d textures.#468
MarkCallow merged 3 commits intomasterfrom
tuket-support_array_textures

Conversation

@MarkCallow
Copy link
Copy Markdown
Collaborator

Based on PR #461 by @tuket. Fixes #454.

  • Fixes array & 3d texture creation.
  • Disables mipmap generation for 3d textures as they need completely different resampling code.
  • Adds tests.
  • Fixes ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

@MarkCallow MarkCallow merged commit b053253 into master Aug 15, 2021
@MarkCallow MarkCallow deleted the tuket-support_array_textures branch August 15, 2021 11:31
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 21, 2024
* Fix array & 3d texture creation.
* Disable mipmap generation for 3d textures as they need completely different resampling code.
* Add tests.
* Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

Co-authored-by: unknown <tuketet@gmail.com>
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
* Fix array & 3d texture creation.
* Disable mipmap generation for 3d textures as they need completely different resampling code.
* Add tests.
* Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

Co-authored-by: unknown <tuketet@gmail.com>
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
* Fix array & 3d texture creation.
* Disable mipmap generation for 3d textures as they need completely different resampling code.
* Add tests.
* Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

Co-authored-by: unknown <tuketet@gmail.com>
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
* Fix array & 3d texture creation.
* Disable mipmap generation for 3d textures as they need completely different resampling code.
* Add tests.
* Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

Co-authored-by: unknown <tuketet@gmail.com>
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
* Fix array & 3d texture creation.
* Disable mipmap generation for 3d textures as they need completely different resampling code.
* Add tests.
* Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

Co-authored-by: unknown <tuketet@gmail.com>
richgel999 pushed a commit to BinomialLLC/KTX-Software-Binomial-Fork that referenced this pull request Mar 9, 2026
* Fix array & 3d texture creation.
* Disable mipmap generation for 3d textures as they need completely different resampling code.
* Add tests.
* Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset.

Co-authored-by: unknown <tuketet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot create 3D files with toktx

2 participants