Merged
Conversation
That path was being added to the include dirs of the library ktx only
when `KTX_FEATURE_VULKAN` was enabled, resulting in a build failure
otherwise:
```
/home/pmoreau/Softwares/KTX-Software/tools/toktx/pngimage.cc:26:10: fatal error: 'dfd.h' file not found
#include "dfd.h"
^~~~~~~
1 error generated.
```
vkloadtests was still being built even if `KTX_FEATURE_VULKAN` was disabled, resulting in missing symbols when loading against the ktx library.
Collaborator
|
I see |
Contributor
Author
That is due to:
|
Collaborator
|
Thank you for the explanation and for this fix. |
Contributor
Author
|
No worries! Thank you for the quick replies and work on the project. |
richgel999
pushed a commit
to BinomialLLC/KTX-Software-Binomial-Fork
that referenced
this pull request
Mar 9, 2026
* CMake: Add path to dfdutils headers for toktx
That path was being added to the include dirs of the library ktx only
when `KTX_FEATURE_VULKAN` was enabled, resulting in a build failure
otherwise:
```
/home/pmoreau/Softwares/KTX-Software/tools/toktx/pngimage.cc:26:10: fatal error: 'dfd.h' file not found
#include "dfd.h"
^~~~~~~
1 error generated.
```
* CMake: Only build *loadtests if corresponding loader enabled
vkloadtests was still being built even if `KTX_FEATURE_VULKAN` was
disabled, resulting in missing symbols when loading against the ktx
library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KTX_FEATURE_VULKANis disabled.KTX_FEATURE_LOADTEST_APPSis enabled butKTX_FEATURE_VULKANis not.