Skip to content

Fix JNI package names in KtxTexture2.cpp#621

Merged
MarkCallow merged 1 commit intoKhronosGroup:masterfrom
Illithidek:master
Aug 15, 2022
Merged

Fix JNI package names in KtxTexture2.cpp#621
MarkCallow merged 1 commit intoKhronosGroup:masterfrom
Illithidek:master

Conversation

@Illithidek
Copy link
Copy Markdown
Contributor

The name of the functions in the JNI KtxTexture2.cpp didn't match
the java package which cause linker error.

The name of the functions in the JNI KtxTexture2.cpp didn't match
the java package which cause linker error.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 14, 2022

CLA assistant check
All committers have signed the CLA.

@MarkCallow
Copy link
Copy Markdown
Collaborator

How come our tests were able to link and run?

@Illithidek
Copy link
Copy Markdown
Contributor Author

Hey, tests just don't use these functions so JNI doesn't call them so the linker doesn't have a problem :)

@Illithidek
Copy link
Copy Markdown
Contributor Author

Basically, JNI works on the promise that somewhere out there we will add a library that will have these functions. Like an "extern" in C. If something is not invoked then the promise doesn't have to be fulfilled.
All other functions works quite well, I found these by luck because I needed to use "needsTranscoding" and a linker error appeared.

@MarkCallow MarkCallow merged commit 758fc86 into KhronosGroup:master Aug 15, 2022
@MarkCallow
Copy link
Copy Markdown
Collaborator

Thanks for the contribution.

richgel999 pushed a commit to BinomialLLC/KTX-Software-Binomial-Fork that referenced this pull request Mar 9, 2026
The name of the functions in the JNI KtxTexture2.cpp didn't match
the java package which cause linker error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants