Color-space and documentation related improvements for ktx create#732
Merged
MarkCallow merged 2 commits intoKhronosGroup:mainfrom Jul 8, 2023
Merged
Color-space and documentation related improvements for ktx create#732MarkCallow merged 2 commits intoKhronosGroup:mainfrom
MarkCallow merged 2 commits intoKhronosGroup:mainfrom
Conversation
MarkCallow
requested changes
Jul 7, 2023
Collaborator
MarkCallow
left a comment
MarkCallow
left a comment
There was a problem hiding this comment.
Looks good. I have 2 minor change requests.
MarkCallow
reviewed
Jul 7, 2023
MarkCallow
approved these changes
Jul 8, 2023
Collaborator
|
Thanks for the fixes. |
Contributor
|
Additions and clarifications look great to me as well – thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ktx create: Adding
noneas an --assign-primaries option (#725)ktx create: Improve usage string and documentation (#726)
ktx create: Allow non-matching input file metadata with warnings (#728)