feat: expand webview i18n lint coverage and remove hardcoded strings#6283
Open
sonwr wants to merge 1 commit intoKilo-Org:mainfrom
Open
feat: expand webview i18n lint coverage and remove hardcoded strings#6283sonwr wants to merge 1 commit intoKilo-Org:mainfrom
sonwr wants to merge 1 commit intoKilo-Org:mainfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| <div class="kilo-notifications-nav"> | ||
| <button class="kilo-notifications-nav-btn" onClick={prev} title="Previous"> | ||
| <Icon name="arrow-left" size="small" /> | ||
| <button class="kilo-notifications-nav-btn" onClick={prev} title={language.t("notifications.previous")}> <Icon name="arrow-left" size="small" /> |
Contributor
There was a problem hiding this comment.
WARNING: Formatting issue — the <Icon> component is on the same line as the button's closing >, with excessive whitespace. This appears to be a merge artifact where the line break was lost. The same issue occurs on line 57.
Suggested change
| <button class="kilo-notifications-nav-btn" onClick={prev} title={language.t("notifications.previous")}> <Icon name="arrow-left" size="small" /> | |
| <button class="kilo-notifications-nav-btn" onClick={prev} title={language.t("notifications.previous")}> |
Contributor
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (25 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #6233 by expanding i18n lint coverage across webview TSX files and replacing remaining hardcoded UI strings with translation keys.
Problem
Some webview TSX files still contained hardcoded user-facing strings, and i18n lint coverage was limited to Agent Manager files only.
Scope
language.t(...)keys.What changed
1) i18n lint/test coverage expansion
packages/kilo-vscode/tests/unit/agent-manager-i18n.test.tspackages/kilo-vscode/tests/unit/webview-i18n.test.tsglobSync("webview-ui/**/*.tsx", { cwd: ROOT, absolute: true })2) Hardcoded UI string removal
Replaced hardcoded literals with translation keys in:
KiloNotifications.tsxPromptInput.tsxProvidersTab.tsxDisplayTab.tsxContextTab.tsxProfileView.tsxApp.tsxAgentBehaviourTab.tsx3) Locale key additions
Added missing keys to locale files (
en+ all existing locale bundles):notifications.dismiss|previous|next|emptyprompt.fileMention.emptyprompt.image.removesettings.providers.selectProvidersettings.display.username.placeholdersettings.context.watcherPatterns.placeholderprofile.accountnav.marketplacesettings.agentBehaviour.*.placeholderand MCP command/url labelsValidation
bunis not available on this host.Risk
Low-to-medium: