Default bash tool output to expanded in chat#6349
Merged
markijbema merged 3 commits intomainfrom Feb 26, 2026
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 files)
|
catrielmuller
approved these changes
Feb 25, 2026
marius-kilocode
approved these changes
Feb 25, 2026
| return ( | ||
| <BasicTool | ||
| {...props} | ||
| defaultOpen // kilocode_change |
Contributor
There was a problem hiding this comment.
WARNING: Hardcoded defaultOpen overrides tool-level default behavior
Setting defaultOpen unconditionally here overrides any props.defaultOpen value passed from the message part pipeline. This can silently bypass existing shell expansion preferences/flags and force all bash tool outputs open, which risks UI noise and unnecessary rendering cost for large command outputs. Consider deriving this from props.defaultOpen (or a dedicated feature flag) instead of hardcoding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultOpen={false}explicitly to override the new defaultThe change is a one-liner in
packages/ui/src/components/message-part.tsx:defaultOpen={props.defaultOpen ?? true}in the bash tool'sBasicToolrender.