feat(agent-manager): add open-file button to diff panel#6359
Open
marius-kilocode wants to merge 6 commits intomainfrom
Open
feat(agent-manager): add open-file button to diff panel#6359marius-kilocode wants to merge 6 commits intomainfrom
marius-kilocode wants to merge 6 commits intomainfrom
Conversation
Each file in the git diff accordion now has an open-file icon button that opens the file in VS Code, resolved against the correct worktree path. The worktree path resolution happens extension-side in AgentManagerProvider via a dedicated agentManager.openFile message.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Addresses all three review comments: - Prefix-matching bypass: appends path.sep for directory boundary check - Symlink traversal: fs.realpathSync resolves both root and target - Cross-platform: path.sep/path.resolve/realpathSync are Windows-aware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentManagerProvidervia a dedicatedagentManager.openFilemessage, keeping the webview free of path construction logicChanges
DiffPanel.tsx: AddedonOpenFilecallback prop and anIconButton(using the existingopen-fileicon) in each accordion file headerAgentManagerApp.tsx: PassesonOpenFilehandler that sendsagentManager.openFilewith session ID and relative pathAgentManagerProvider.ts: NewopenWorktreeFile()method that resolves the worktree path from the session state and opens the file viavscode.workspace.openTextDocument