fix: agent manager terminal follows context when switching to local mode#6360
Open
marius-kilocode wants to merge 2 commits intomainfrom
Open
fix: agent manager terminal follows context when switching to local mode#6360marius-kilocode wants to merge 2 commits intomainfrom
marius-kilocode wants to merge 2 commits intomainfrom
Conversation
When switching from a worktree to local mode with a pending tab, currentSessionID() was undefined causing terminal triggers (Cmd+/ and button click) to silently do nothing. Added a showLocalTerminal fallback that opens a terminal at workspace root, and showExistingLocalTerminal to auto-reveal the local terminal when switching contexts.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional observations outside diff hunks. Files Reviewed (5 files)
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| const cwd = vscode.workspace.workspaceFolders?.[0]?.uri.fsPath | ||
| if (!cwd) { | ||
| this.log("showLocalTerminal: no workspace folder open") | ||
| return |
Contributor
There was a problem hiding this comment.
WARNING: Local terminal failure is silent when no workspace is open
In SessionTerminalManager.showLocalTerminal(), this branch only logs and returns when cwd is missing, so the user gets no visible feedback after invoking terminal actions from local mode. SessionTerminalManager.showTerminal() already surfaces this case via showWarningMessage, so behavior is currently inconsistent and can look like a broken command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currentSessionID()wasundefined, causing the terminal keyboard shortcut (Cmd+/) and button click to silently do nothing.showLocalTerminalmessage/handler that opens a terminal at workspace root when triggered in local mode without an active session.showExistingLocalTerminalmessage/handler to auto-reveal the local terminal when switching contexts (mirrors the existingshowExistingbehavior for worktree sessions).Changes
SessionTerminalManager.tsshowLocalTerminal()method using__local__keyAgentManagerProvider.tsshowLocalTerminalandshowExistingLocalTerminalmessagesAgentManagerApp.tsxselectLocal()sendsshowExistingLocalTerminalfor pending tabsmessages.tsShowLocalTerminalRequestandShowExistingLocalTerminalRequesttypesagent-manager-arch.test.ts