Refactor logging for _adjust_charge_balance#162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 83.09% 83.09%
=======================================
Files 9 9
Lines 1479 1479
Branches 319 319
=======================================
Hits 1229 1229
Misses 214 214
Partials 36 36 ☔ View full report in Codecov by Sentry. |
|
I realized that I made the push changes directly from my |
That's technically OK. The reason to use branches on your fork is that it's often convenient to keep the |
|
Closes #160 |
Refactor logging for
_adjust_charge_balanceDescription:
line 2298to remove the redundant log message “Solution is not electroneutral (C.B. = {cb} eq/L).”Minor changes:
line 2298toself.logger.info(f"Adjusting {self._cb_species} to compensate.")line 2291remains asself.logger.info(f"Solution is not electroneutral (C.B. = {cb} eq/L).")