Fix mass conservation for H+ and OH- in Solution.__add__ following #270#274
Merged
rkingsbury merged 6 commits intomainfrom Aug 8, 2025
Merged
Fix mass conservation for H+ and OH- in Solution.__add__ following #270#274rkingsbury merged 6 commits intomainfrom
rkingsbury merged 6 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 81.90% 83.63% +1.72%
==========================================
Files 9 9
Lines 1503 1460 -43
Branches 261 251 -10
==========================================
- Hits 1231 1221 -10
+ Misses 226 210 -16
+ Partials 46 29 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#270 introduced a change to
Solution.__add__that inadvertently broke mass conservation of H+ and OH- species when adding solutions. This PR fixes that issue. In brief,__add__now relies on conservation of mass of H+ and OH- in thecomponentsattribute to determine the new pH of the mixed solution.