added a nested parameter to 2 methods in the Solution class#284
Merged
rkingsbury merged 3 commits intoKingsburyLab:mainfrom Oct 13, 2025
Merged
added a nested parameter to 2 methods in the Solution class#284rkingsbury merged 3 commits intoKingsburyLab:mainfrom
rkingsbury merged 3 commits intoKingsburyLab:mainfrom
Conversation
5 tasks
Member
|
Looks great @vineetbansal; thanks for adding the type hints in! Can you please update the CHANGELOG as well? I'm just going to make sure tests pass on our CI and then I'll merge. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 84.72% 84.78% +0.06%
==========================================
Files 9 9
Lines 1460 1466 +6
Branches 251 255 +4
==========================================
+ Hits 1237 1243 +6
Misses 193 193
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Thanks @rkingsbury - I've updated the changelog (added bullet point under the "unreleased" heading). |
Member
|
Thanks @vineetbansal , merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new
nestedargument to two methods in theSolutionclass, as per our discussions wrt issue #229Old behavior is unchanged. At some future point we might consider only having
nested=Truesupported (and subsequently remove the argument altogether).Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.Tip: Install
pre-commithooks to auto-check types and linting before every commit: