CI run with pinned deps common to all py/platforms#314
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 10 10
Lines 1607 1607
Branches 285 285
=======================================
Hits 1377 1377
Misses 194 194
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, thanks @vineetbansal . I see the floating dependencies remain in
? Otherwise, the floating deps in |
|
@rkingsbury - yes, that's correct. The way we've seen it widely used is:
The new workflow introduced here helps us check if we broke our code w.r.t. dependencies which were working before. The |
Summary
Once CI on this PR passes, this should simplify things quite a bit by hard-coding dependencies that are guaranteed to work on all platforms (and supported python versions) in a
requirements.txtfile, in addition to the CI workflows on floating dependencies that already exist.If the goal is reproducibility-if-all-else-fails from the point of view of the users, then they'll find dealing with a
requirements.txtmuch easier. The added workflow will give the developers some time to fix the code in case the code does start failing on account of an updated dependency.AFAIK no workflow is utilizing the platform-specific files in the
requirements/folder at all.Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.