Fix the postprocess workflow; refactor PHREEQC2026 wrapper#318
Fix the postprocess workflow; refactor PHREEQC2026 wrapper#318rkingsbury merged 10 commits intomainfrom
Conversation
|
@rkingsbury - perhaps we can revisit permissions here. I'm getting a: Of course I'm not trying to push to If the fix is not obvious and you're okay with it, perhaps you can give me temporary admin access till we fix this part. |
|
Thanks for checking on this @vineetbansal ! Fingers crossed it works. I've just upgraded your role to |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 85.68% 86.59% +0.90%
==========================================
Files 10 14 +4
Lines 1607 1842 +235
Branches 285 320 +35
==========================================
+ Hits 1377 1595 +218
- Misses 194 203 +9
- Partials 36 44 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…module, with pyEQL.phreeqc being the pure-python wrappers
…EQL.phreeqc.IS_AVAILABLE boolean flag
|
@rkingsbury - assuming the CI passes on the latest commit, I'd say I'm done with this PR. The core changes in this PR are:
The same would be used by a user if they're on an exotic platform (and a regular or simply:
and in one of our phreeqc-engine-specific tests like this: This same utility variable can be used in rest of the
As long as things look good, we should probably merge this PR and re-update the |
rkingsbury
left a comment
There was a problem hiding this comment.
Looks great @vineetbansal ! Please make a note to capture the contents of your explanatory post in the documentation somewhere (in a future PR).
I noticed that the post-process workflow for
pyEQL(on which the release workflow depends) is currently broken. This PR attempts to fix it.This is a WIP - I'm triggering the post-process workflow on all PRs to
main(so we can fix this before merging it), not just merged ones, and running all steps except the final publish-to-pypi in the release workflow. These two changes will be reverted once everything else works.