Merged
Conversation
Updated volume assertions to compare magnitudes for accuracy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 14 14
Lines 1856 1856
Branches 322 322
=======================================
Hits 1602 1602
Misses 208 208
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solution.from_dictcontains logic to ensure that the volume of theSolutionthat is created is exactly equal to that stored in the dictionary. Small differences can arise in the event that, for example,equilibrate()was called on the original solution and updated the volume. This might result in a slightly final volume than what would be calculated on__init__.Solution.from_file, which is used byfrom_preset, did not contain this logic in the case of loadingyamlfiles. Forjsonfiles,loadfncallsfrom_dictinternally, so the volume adjusting logic was used.For example, loading the
seawaterpreset prior to this PR resulted in a slight change in volume:This PR adds the subtle volume correction to
from_file(for YAML files) and makes several improvements to the associated unit tests.