Skip to content

Adjust DeprecationWarning#348

Merged
rkingsbury merged 5 commits intoKingsburyLab:mainfrom
SuixiongTay:deprecation_warning
Feb 12, 2026
Merged

Adjust DeprecationWarning#348
rkingsbury merged 5 commits intoKingsburyLab:mainfrom
SuixiongTay:deprecation_warning

Conversation

@SuixiongTay
Copy link
Copy Markdown
Collaborator

Summary

@rkingsbury
Copy link
Copy Markdown
Member

Thank you @SuixiongTay ! This closes #345

@rkingsbury rkingsbury merged commit 2c6ff02 into KingsburyLab:main Feb 12, 2026
15 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.31%. Comparing base (541c6db) to head (e29b282).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/pyEQL/solution.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   86.42%   86.31%   -0.11%     
==========================================
  Files          14       14              
  Lines        1856     1856              
  Branches      322      322              
==========================================
- Hits         1604     1602       -2     
- Misses        207      208       +1     
- Partials       45       46       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SuixiongTay
Copy link
Copy Markdown
Collaborator Author

Hi @rkingsbury , I don't remember why the Cl did not pass completely for this PR. Should we revert and correct the code coverage before merging? Thanks!

@rkingsbury
Copy link
Copy Markdown
Member

rkingsbury commented Feb 12, 2026

Hi @rkingsbury , I don't remember why the Cl did not pass completely for this PR. Should we revert and correct the code coverage before merging? Thanks!

Thanks for asking, but no it's OK. Everything passed except the codecov reports. The codecov reports are not 100% reliable, and I just use them as a guideline to help see if newly-added code lacks tests. But this is a simple PR with a temporary DeprecationWarning (not actually affecting any output or calculations), so I'm not concerned about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants