Adjust DeprecationWarning#348
Conversation
|
Thank you @SuixiongTay ! This closes #345 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 86.42% 86.31% -0.11%
==========================================
Files 14 14
Lines 1856 1856
Branches 322 322
==========================================
- Hits 1604 1602 -2
- Misses 207 208 +1
- Partials 45 46 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @rkingsbury , I don't remember why the Cl did not pass completely for this PR. Should we revert and correct the code coverage before merging? Thanks! |
Thanks for asking, but no it's OK. Everything passed except the codecov reports. The codecov reports are not 100% reliable, and I just use them as a guideline to help see if newly-added code lacks tests. But this is a simple PR with a temporary |
Summary
DeprecationWarning#345