🚧Update CICD to the latest version#169
Merged
KinsonDigitalAdmin merged 3 commits intopreview/v1.0.0-preview.12from May 8, 2023
Merged
🚧Update CICD to the latest version#169KinsonDigitalAdmin merged 3 commits intopreview/v1.0.0-preview.12from
KinsonDigitalAdmin merged 3 commits intopreview/v1.0.0-preview.12from
Conversation
8 tasks
KinsonDigitalAdmin
requested changes
May 8, 2023
Contributor
KinsonDigitalAdmin
left a comment
There was a problem hiding this comment.
I caught something that we missed. We need to update the .nuke/parameters.json file as shown below.
{
"$schema": "./build.schema.json",
"Solution": "CASL.sln",
"RepoOwner": "KinsonDigital",
"RepoName": "CASL",
"ProjectName": "CASL",
- "PreProcessReadMe": true
+ "PreProcessReadMe": true,
+ "SkipNugetChecks": false
}|
Kudos, SonarCloud Quality Gate passed!
|
KinsonDigitalAdmin
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Preview Feature Pull Request
📋Review Checklist📋
The head(source) branch for this pull request is a preview feature branch, with the correct naming syntax, in the following example:
A head(source) branch is the branch being merged into a target branch.
Example
The head(source) branch for this pull request is created from a preview release branch, with the correct naming syntax, in the following example:
Example
The base(target) branch for this pull request is a preview release branch, with the correct naming syntax, in the following example:
A base(target) branch is the branch that the head(source) branch is merging into.
Example
💡For more information on branching, refer to the project's branching documentation.
Associated issue exists and is linked to this pull request.
Pull request title matches the title of the associated issue.
A
previewlabel has been added to the pull request.The labels attached to this PR match the labels attached to the associated issue.
Project assigned matches the project of the associated issue.
Milestone assigned matches the milestone of the associated issue.
My code follows the coding style of this project.
I have manually tested my code changes to the best of my ability.
All tests passed locally.