Do not force commit on collection delete#3658
Merged
Conversation
leplatrem
force-pushed
the
do-not-force-commit-on-purge-deleted-views
branch
from
24f978b to
2b84156
Compare
alexcottner
reviewed
Feb 25, 2026
| run: | | ||
| pip install tomli coveralls | ||
| coveralls --service=github | ||
| coveralls --service=github || true |
Contributor
There was a problem hiding this comment.
Oh, I see that coveralls is failing...
alexcottner
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced by #3618
purge_deleted()is also used in collection deleted hook and shouldn't force commit.kinto/kinto/views/collections.py
Line 57 in 3bcd6cd
This was unveiled in Kinto/kinto-emailer#502 which leverages transactions lifecycles to send emails