Clean up param "workers" in WSGIMiddleware#1146
Merged
JayH5 merged 2 commits intoKludex:masterfrom Jun 13, 2021
Merged
Conversation
7165108 to
5f910c8
Compare
Contributor
Author
|
I was just watching the code and finding how Starlette works, noticed there's a weird param "workers" not needed by any functions, and opened a pr. I noticed a thumb down here. Sorry to submit such a trifling change. Maybe this pr is unnecessary cause the I'll handle the decision to the maintainers. BTW, force pushed once to fix linting. The checks reported a coverage fail, not sure how it's related to my commit. |
Contributor
|
Thanks for the PR. I think we can just remove this parameter since it hasn't actually done anything for a long time. |
Param "workers" in WSGIMiddleware.__init__ has not been used since 0.6.3, which is changed in KludexGH-164, commit 96c51c.
5f910c8 to
decb8e8
Compare
Contributor
Author
|
Changed the fix to cleaning up. |
JayH5
approved these changes
Jun 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Param
workersinWSGIMiddleware.__init__has not been usedsince 0.6.3, which is changed in GH-164, commit 96c51c9.
We formerly used a
ThreadPoolExecutor, which support setting worker numbers. Later it was changed to used the default executor.I don't think anyone is still using the "worker" param after more than 2 years.
But out of caution, only made aThe parameter was removed.DeprecationWarningfirst. Cause I'm not sure which is the correct time to obsolete this param in init, just gave a release number "1.0", which may need to be adjusted.