Change websockets version to v9#1038
Merged
euri10 merged 2 commits intoKludex:masterfrom May 27, 2021
Merged
Conversation
2 tasks
Co-authored-by: Sören Sprößig <36265207+ssproessig-thales@users.noreply.github.com>
ssproessig-thales
approved these changes
May 21, 2021
ssproessig-thales
approved these changes
May 21, 2021
Contributor
|
I haven't followed quite closely the changes upstream so let's see what the CI says, ! |
euri10
approved these changes
May 27, 2021
Contributor
euri10
left a comment
euri10
left a comment
There was a problem hiding this comment.
the CI says tests pass ! thanks @heavenshell
Contributor
Author
|
Thank you so much!! |
Contributor
|
@euri10 @ssproessig-thales Note that websockets9 causes a Deprecation warning: I guess this will need to be fixed before websockets10 |
Contributor
|
Interesting, I would have thought the pytest configuration we have would have make this fail, since we essentially use all strict settings, or we didn't merge it I'm not sure now, wil check later, thanks for the heads up |
Contributor
Contributor
Contributor
|
ok so if we got this merged the CI here would have failed as I thought,
https://github.com/encode/uvicorn/pull/929/checks?check_run_id=2691822451
…On Fri, May 28, 2021 at 8:14 AM LincolnPuzey ***@***.***> wrote:
@euri10 <https://github.com/euri10> Looks like #929
<#929> is still open
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1038 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAINSPXULVR4RDEQBVVP52LTP4YEVANCNFSM44RBLQZA>
.
|
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* Change websockets version to v9 * Update setup.py Co-authored-by: Sören Sprößig <36265207+ssproessig-thales@users.noreply.github.com> Co-authored-by: Sören Sprößig <36265207+ssproessig-thales@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
websocket v9 was released.
https://pypi.org/project/websockets/
I update setup.py's
extra_requirementsThank you!