removed tab override in codemirror extension #9364
Open
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gowrimanoharir
changed the title
pavkout
approved these changes
Nov 27, 2025
Contributor
pavkout
left a comment
pavkout
left a comment
There was a problem hiding this comment.
I tested it, and everything works as expected. Thanks for your help.
pavkout
force-pushed
the
001-tab-autocomplete
branch
from
7ccd81f to
2dfe879
Compare
Author
|
@pavkout thanks for the approval, the workflow still says Test Expected please let me know I any should be done for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes-#7713
Background
Looks like the default code mirror behavior was overridden in the original PR when autocomplete was implemented, to not allow
tabkey to autocomplete#112
Changes
Removing the override so it reverts to default code mirror behavior allowing
tabto autocomplete suggestionsTested in local, can upload videos if needed.