Fix(diagnostics): continue get/describe on errors in diagnostics#1492
Merged
randmonkey merged 2 commits intomainfrom Mar 11, 2026
Merged
Fix(diagnostics): continue get/describe on errors in diagnostics#1492randmonkey merged 2 commits intomainfrom
randmonkey merged 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
+ Coverage 41.27% 41.28% +0.01%
==========================================
Files 57 57
Lines 3741 3742 +1
==========================================
+ Hits 1544 1545 +1
+ Misses 1952 1951 -1
- Partials 245 246 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
randmonkey
force-pushed
the
fix/diag_continue_describe_on_errors
branch
from
e51966e to
644a8f0
Compare
pmalek
approved these changes
Mar 11, 2026
pmalek
reviewed
Mar 11, 2026
Comment on lines
+69
to
+72
| // Review: Should we traverse the list manually instead of describing all in one command? The `describe <resource-type> -A` actually performs like: | ||
| // - List all resources | ||
| // - Describe the resources one by one | ||
| // In the process of diagnostics, the cleanup is in process and some resources may disappear so errors may happen and we lose the describe result for remaining resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the get all/dump all step in diagnostics stops on errors in executing commands. It would fail if there are resources gets deleted during the dumping:
When this happens, the getAll and describe all stops and dump of other resources are skipped. We should continue the dumping of other resources anyways to dump as much information as we can.