Wrong report during when match when block (wrong REDUNDANT_ELSE_IN_WHEN)

[Decodetalkers]

kotlin-lsp said the else is needless, but in fact it is

sealed class Resource<out T> {
    data object Loading : Resource<Nothing>()
    data object Begin : Resource<Nothing>()
    data class Success<out T>(val data: T) : Resource<T>()
    data class Failure(val message: String) : Resource<Nothing>()
}

so it was a wrong report

[fedochet]

Hi there @Decodetalkers! Thank you, reproduced!

Small reproducer:

sealed class Resource<out T> {
    data object Loading : Resource<Nothing>()
    data object Begin : Resource<Nothing>()
    data class Success<out T>(val data: T) : Resource<T>()
    data class Failure(val message: String) : Resource<Nothing>()
}

fun usage(resource: Resource<List<String>>) {
    // val resource: Resource<List<String>> = Resource.Loading
    when (resource) {
        is Resource.Loading -> println("Loading")
        is Resource.Begin -> println("Begin")
        else -> println("Other")
    }
}

[fedochet]

Internal issue: LSP-1035

[fedochet]

The issue is addressed and is going to be fixed in the next release 🎉

[jorrit200]

Seems related to an old issue of mine about sealed interfaces (I had not tested sealed classes): #124

Will the planned fix also address this?

[fedochet]

@jorrit200 thank you for noticing that! I believe that this is indeed the same issue; hence it should be fixed as well!