Skip to content

UI wrapper for shira#24

Open
Maxikozie wants to merge 10 commits intoKraXen72:masterfrom
Maxikozie:master
Open

UI wrapper for shira#24
Maxikozie wants to merge 10 commits intoKraXen72:masterfrom
Maxikozie:master

Conversation

@Maxikozie
Copy link
Copy Markdown

@Maxikozie Maxikozie commented Apr 6, 2025

Simple UI, log needs some work

@KraXen72
Copy link
Copy Markdown
Owner

KraXen72 commented Apr 6, 2025

Hi, thank you for opening the pull request.

  • Please revert to the changes to the readme.
  • The dropdowns and the scrollbars are using an older style, not a breeze theme for QT, so could you please look into that? (See my screenshot in the original issue.)
  • There are some CLI options that are not covered by the UI, so please include checkboxes and inputs for those as well. Feel free to include multiple tabs at the top, if necessary.
  • What does the drop down for different services do? Is it even necessary? I'd suggest removing it, since shira can handle the different links dynamically. The service specific settings, if any, can be included in their respective top tabs.
  • Whatever work you need to do on the log, please do so. I noticed that the progress doesn't update the same line, but it creates a new one. Is there anything that can be done about that?
  • Please add a config file support with a file picker and a button to locate the resulting file in the file manager.
  • If I think of anything else, I'll let you know.

Thanks for that work so far!

@Maxikozie
Copy link
Copy Markdown
Author

Thx for the workpoints
Exams are starting soon tho, so imma focus on that but ill squeeze out some time for this

@KraXen72
Copy link
Copy Markdown
Owner

KraXen72 commented Apr 7, 2025

no worries! take your time

@Zogsquared
Copy link
Copy Markdown

Just wanted to say I've been thinking about making my own UI for shira as I use it for all my music now and would make use simple and just look pretty so seeing this branch has made me really excited and am looking forward to the merge!

well done guys u are amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants