Simplify the code for authenticating to GitHub#33
Simplify the code for authenticating to GitHub#33DilumAluthge wants to merge 1 commit intoKristofferC:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage ? 25.21%
=========================================
Files ? 6
Lines ? 797
Branches ? 0
=========================================
Hits ? 201
Misses ? 596
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1947770 to
7a0e707
Compare
|
@KristofferC @IanButterworth Could you review this? |
|
Claude review: Review of PR #33: Simplify the code for authenticating to GitHubThe refactor is a good simplification — removing the lazy Bug — wrong variable name in
|
After #24, all calls to the GitHub API are done through GitHub.jl. So then there's no need to keep a custom
GitHubAuthenticatorstruct around. Just callGitHub.authenticate()one time at the very beginning, and store the resultingGitHub.Authorizationin the config. Yes,GitHub.Authorizationis an abstract type, but I don't think that matters much here; most of the time will be spent on these network calls, so the overhead when readingconfig.authwon't matter much.