Extend RegisteredDataStore with upstream storage#1806
Merged
philbrookes merged 3 commits intoKuadrant:mainfrom Mar 11, 2026
Merged
Extend RegisteredDataStore with upstream storage#1806philbrookes merged 3 commits intoKuadrant:mainfrom
philbrookes merged 3 commits intoKuadrant:mainfrom
Conversation
43db493 to
5372412
Compare
KevFan
previously approved these changes
Mar 11, 2026
Add RegisteredUpstreamKey, RegisteredUpstreamEntry, and TargetRef types to support storing registered upstream configurations per policy. Include CRUD methods (SetUpstream, GetUpstream, GetAllUpstreams, DeleteUpstream), filtering by TargetRef (GetUpstreamsByTargetRef), and policy-scoped cleanup via extended ClearPolicyData. Update manager.go to handle the new third return value and trigger notifications on upstream changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: Phil Brookes <pbrookes@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: Phil Brookes <pbrookes@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Phil Brookes <pbrookes@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
5372412 to
100ac55
Compare
KevFan
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegisteredUpstreamKey,RegisteredUpstreamEntry, andTargetReftypes toRegisteredDataStorefor storing registered upstream configurations per policySetUpstream,GetUpstream,GetAllUpstreams,GetUpstreamsByTargetRef,DeleteUpstream) with concurrency-safe lockingClearPolicyDatato also clean up registered upstreams when a policy is removedmanager.goto handle the new return value and trigger notifications on upstream changesReview and local verification
Verify:
RegisteredDataStoretests still pass (ClearPolicyData callers updated from 2 to 3 return values)GetUpstreamsByTargetReffilters entries by target referenceCloses #1790
🤖 Generated with Claude Code