fix: unify model picker background updates and model context display#77
Open
k99k5 wants to merge 2 commits intoKuberwastaken:mainfrom
Open
fix: unify model picker background updates and model context display#77k99k5 wants to merge 2 commits intoKuberwastaken:mainfrom
k99k5 wants to merge 2 commits intoKuberwastaken:mainfrom
Conversation
Keep provider model-list fetching, notification ticking, cost/token sync, and task overlay refresh in the actual CLI main loop while removing the duplicate dead-path logic from App::run(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@k99k5 could you please resolve the merge conflicts? This looks like a nice, simple codebase cleanup. |
Author
|
ok
…---Original---
From: "Adam Václav ***@***.***>
Date: Mon, Apr 13, 2026 01:59 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [Kuberwastaken/claurst] fix: unify model picker background updates and model context display (PR #77)
AdamBajger left a comment (Kuberwastaken/claurst#77)
@k99k5 could you please resolve the merge conflicts? This looks like a nice, simple codebase cleanup.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App::runWhy
The interactive runtime is driven by
src-rust/crates/cli/src/main.rs, while some model picker background update logic still lived insrc-rust/crates/tui/src/app.rs::run(). That duplication made the ownership of runtime UI updates unclear and left dead-path behavior in thecodebase.
This change makes the real loop responsible for model picker background updates, removes the duplicated branch in
App::run(), and improves modelcontext window presentation so the picker shows more consistent and less misleading values.