Skip to content

Add system tests#104

Open
shilpabasu22 wants to merge 2 commits intodevelopmentfrom
add-system-tests
Open

Add system tests#104
shilpabasu22 wants to merge 2 commits intodevelopmentfrom
add-system-tests

Conversation

@shilpabasu22
Copy link
Copy Markdown

Link to Click Up ticket

Add a link to the JIRA ticket that the changes in this PR describe.

Describe this PR

System tests for various GET requests on accounts api

What is the problem we're trying to solve

Add a summary of the problem and any additional context that helps explain what the issue we're trying to solve is.

What changes have we introduced

Add descriptions of what changes were made to address the problem and provide a solution.

Include any links to commits that introduce significant additions of code if they help explain the process of coming to the solution. e.g Addition of test database setup, addition of first test and production class, removal of buggy code, etc.

Checklist

  • Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
  • Added tests to cover all new production code
  • Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • Checked all code for possible refactoring
  • Code pipeline builds correctly

Follow up actions after merging PR

Are there any next steps that need to addressed after merging this PR? Add them here.

@FaisalHackney
Copy link
Copy Markdown
Contributor

We need a yml file to specify how the values for the following keys are accessed from circle-ci context:

  • "AWS_ACCESS_KEY"
  • "AWS_SECRET_ACCESS_KEY"
  • "AWS_SESSION_TOKEN"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants