Skip to content

Add NullOrWhitespace check in ViewPropertyCautionaryAlerts endpoint. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LBHCallumM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add NullOrWhitespace check in ViewPropertyCautionaryAlerts endpoint. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CautionaryAlertsApi.Tests/V1/Controllers/CautionaryAlertsControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,19 @@ public void CatchesAndReturnsNotFoundWhenUseCaseThrowsPropertyAlertNotFoundExcep
response.Value.Should().Be($"Property cautionary alert(s) for property reference {propertyReference} not found");
response.StatusCode.Should().Be(404);
}

[TestCase("")]
[TestCase(" ")]
[TestCase(null)]
public void ViewPropertyCautionaryAlertsWhenTagRefIsNullOrWhiteSpaceReturnsBadRequest(string tagRef)
{
// Arrange

// Act
var response = _classUnderTest.ViewPeopleCautionaryAlerts(tagRef, string.Empty) as BadRequestObjectResult;

// Assert
response.StatusCode.Should().Be(400);
}
}
}
7 changes: 7 additions & 0 deletions CautionaryAlertsApi/V1/Controllers/CautionaryAlertsApiController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,20 @@ public CautionaryAlertsApiController(IGetAlertsForPeople getAlertsForPeople, IGe
/// <param name="personNo">The number of the person you are interested in within a property. person_no in UH. e.g. 01</param>
/// <response code="200">Successful. One or more records found for given tag_ref and person_no</response>
/// <response code="404">No records found for given tag_ref and person_no</response>
/// <response code="400">Bad request - tag_ref cannot be null or whitespace</response>
[ProducesResponseType(typeof(ListPersonsCautionaryAlerts), StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status404NotFound)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
[HttpGet]
[Route("people")]
public IActionResult ViewPeopleCautionaryAlerts([FromQuery(Name = "tag_ref"), BindRequired] string tagRef,
[FromQuery(Name = "person_number")] string personNo)
{
if (string.IsNullOrWhiteSpace(tagRef))
{
return BadRequest($"Parameter {nameof(tagRef)} cannot be null or whitespace");
}

try
{
return Ok(_getAlertsForPeople.Execute(tagRef, personNo));
Expand Down