Skip to content

Change JWT core from being an implicit dependency to explicit one, and bump to v1.87.0.#46

Merged
Duslerke merged 1 commit intomasterfrom
bump-jwt-for-cognito-token-support
Feb 27, 2026
Merged

Change JWT core from being an implicit dependency to explicit one, and bump to v1.87.0.#46
Duslerke merged 1 commit intomasterfrom
bump-jwt-for-cognito-token-support

Conversation

@Duslerke
Copy link
Copy Markdown
Contributor

@Duslerke Duslerke commented Feb 26, 2026

What:

  • Make Hackney.Core.JWT be an explicit dependency instead of an implicit one.
  • Update the Hackney.Core.JWT package multiple versions up (1.30 -> ... -> 1.87).

Why:

  • This C# solution is directly referencing the JWT core package across both its projects: using JWT namespaces, methods, and interfaces. Issue is that this package is not referenced as a direct dependency within the .csproj files. Instead, package is imported through Hackney.Core.Authorization. When the restore happens, Authorization package is build, which contains the binaries from JWT due to a weak link between the 2.
  • To get the latest version of the ITokenFactory implementation that adds support for the Cognito token schema.

Notes:

  • What changes does latest JWT intoduce? See PR: Add cognito authentication flow token schema support. lbh-core#68.
  • These changes do not require immediate deployment, they merely need to be present within the repo's main branch. This is so those changes would already be there for when anyone would introduce new changes attempting to access Google groups from the token. Without this JWT version bump, any attempted access of Groups within the token would make the API wouldn't fall over.

@Duslerke Duslerke requested a review from a team as a code owner February 26, 2026 17:24
@Duslerke Duslerke merged commit 968e90b into master Feb 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants