Conversation
|
Will have to double check this weekend to ensure this works but for the most part I'll most definitely merge this in |
|
If this doesn’t break anything I would love to see this merged. I don’t
remember why or where we used Guava.
…On Wed, Jan 5, 2022 at 15:07 Shanyu Juneja ***@***.***> wrote:
Will have to double check this weekend to ensure this works but for the
most part I'll most definitely merge this in
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5NBPO6QHFILSFL5CZ6EUDUUSQH7ANCNFSM5LKSNPEA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I replaced guava usage with their equivalents, should not break anything. There are tests, but I'm not sure if the changes I made are tested though, but I'm pretty sure I did not miss anything. |
terminalsin
left a comment
There was a problem hiding this comment.
As I imagined there are issues with the property-framework module failing to pass as it makes use of Guava's Eventbus. Am looking into whether we can even just remove the framework as it's unused.
I'll see what can be done about that. Guava does not allow to only shade the eventbus, though. |
Same commit as the previous one, it removes all usages of guava from the project, since there are not so many of them.