Open
Conversation
Member
FYI Shift + Insert and Shift + Delete already do this. |
Author
|
Thanks for pointing that out, I've removed those two extra shortcuts and updated tooltips to reflect the existing shortcuts. |
PhysSong
reviewed
Jul 9, 2023
Contributor
|
@davidovski If you want to get this merged, it would be nice if you could fix PhysSong's comment and solve the merge conflict. |
rubiefawn
force-pushed
the
keyboard_shortcuts
branch
from
130b24c to
d006266
Compare
While the documentation suggests using + (or | for Qt 6) for combining key sequences, keys and modifier keys are of different enum types, which raises the deprecated-enum-enum-conversion warning, which results in a failed compilation due to our use of -Werror. Fun! This isn't the first time this exact thing has been a problem, which is why combine() in include/DeprecationHelper.h exists. This commit uses that. https://doc.qt.io/archives/qt-5.15/qkeysequence.html#details https://doc.qt.io/qt-6/qkeysequence.html#details
Contributor
|
I've fixed the merge conflict and any resulting compile errors, so if there's still interest in this PR, it should no longer be blocked on those issues. |
Member
|
As a heads-up, |
Also update `combine()` to `keySequence()` due to Qt6 upgrade
PhysSong
reviewed
Nov 6, 2025
so i don't have to clone this repo again lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve ease of usability throughout the DAW, adding useful keyboard shortcuts.
I felt like these actions were missing shortcuts and I have personally found these very helpful. I have added relevant tooltips where appropriate, however I'm not sure the best way to signpost the Ctrl+D shortcut.
As this is my first pull request, any criticism is greatly appreciated. Thank you!