Allow export of only the selected notes#7991
Merged
michaelgregorius merged 2 commits intoLMMS:masterfrom Jul 6, 2025
Merged
Conversation
User can now choose if they only want to export the selected notes when exporting a MIDI clip as an `xpt` or `xptz` file in the piano roll. ## Technical details Add the new public method `exportToXML` to `MidiClip`. Compared to `saveSettings` it has an additional parameter `onlySelectedNotes` which controls which notes are exported. The default is to export all notes. The method `saveSettings` now simply delegates to `exportToXML` using the default. `PianoRollWindow::exportMidiClip` now adds a check box to the export dialog which lets users select if they only want to export the selected notes or all notes. The default is to export all notes. The method now uses the new method `exportToXML` for the export and passes the state of the check box into the method.
1 task
1 task
regulus79
approved these changes
Jul 5, 2025
Member
regulus79
left a comment
regulus79
left a comment
There was a problem hiding this comment.
Code looks fine. I tested it a bit, and it seems to work as expected.
Change the text from "Only selected notes" to "Export only selected notes" so that it becomes clearer what the checkbox affects/controls.
Contributor
Author
|
With commit 7251627 I have changed the checkbox text from "Only selected notes" to "Export only selected notes" so that it becomes clearer what the checkbox affects/controls. Otherwise nothing has changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can now choose if they only want to export the selected notes when exporting a MIDI clip as an
xptorxptzfile in the piano roll.The export dialog now has a check box which lets users choose to only export the selected notes:
Technical details
Add the new public method
exportToXMLtoMidiClip. Compared tosaveSettingsit has an additional parameteronlySelectedNoteswhich controls which notes are exported. The default is to export all notes. The methodsaveSettingsnow simply delegates toexportToXMLusing the default.PianoRollWindow::exportMidiClipnow adds a check box to the export dialog which lets users select if they only want to export the selected notes or all notes. The default is to export all notes. The method now uses the new methodexportToXMLfor the export and passes the state of the check box into the method.