feat(core): add APL component trait interfaces and composition pattern#137
Merged
ncipollina merged 2 commits intomainfrom Mar 5, 2026
Merged
feat(core): add APL component trait interfaces and composition pattern#137ncipollina merged 2 commits intomainfrom
ncipollina merged 2 commits intomainfrom
Conversation
Introduces IMultiChildComponent, IActionableComponent, and ITouchableComponent interfaces with corresponding sealed trait classes (MultiChildComponentTrait, ActionableComponentTrait, TouchableComponentTrait) to support multi-inheritance via composition. Refactors Container, GridSequence, Pager, Sequence, ActionableComponent, and TouchComponent to implement these interfaces using composition. Adds FlexSequence as a new scrollable flex-layout component. Also adds missing properties to ScrollView (AllowForward, AllowBackwards), Text (OnTextLayout), and Video (ScreenLock), and adds full XML documentation to all new interfaces and trait classes. Co-Authored-By: Claude <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7fde7915c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Introduces a trait-based composition pattern for APL components to support multi-inheritance across the component hierarchy. Rather than duplicating properties across components, shared behaviour is now expressed via interfaces with sealed trait backing classes.
New trait interfaces & classes:
IMultiChildComponent/MultiChildComponentTrait—Data,FirstItem,Items,LastItem,OnChildrenChangedIActionableComponent/ActionableComponentTrait—OnBlur,OnFocus,HandleKeyDown,HandleKeyUpITouchableComponent/TouchableComponentTrait—Gestures,OnCancel,OnDown,OnUp,OnMove,OnPressRefactored components (now implement interfaces via composition):
Container,GridSequence,Pager,Sequence→IMultiChildComponentActionableComponent→IActionableComponentTouchComponent→ITouchableComponentNew component:
FlexSequence— scrollable flex-layout container implementingIMultiChildComponentAdditional property additions:
ScrollView:AllowForward,AllowBackwardsText:OnTextLayoutVideo:ScreenLockAll new interfaces and trait classes include full XML documentation.
✅ Checklist
🧪 Related Issues or PRs
Closes #...
💬 Notes for Reviewers
sealedand[JsonIgnore]d — they exist purely as composition backing stores and never appear in serialized output.RegisterTypeInfo<T>()on each trait class callsAlexaJsonOptions.RegisterTypeModifierso that custom JSON converters are applied regardless of which concrete component type is being serialized.FlexSequenceis registered inAPLComponentConverterso it participates in polymorphic deserialization.// IMultiChildComponentdelegating properties — consistent with the pattern established inContainer.🤖 Generated with Claude Code