This repository was archived by the owner on Jul 23, 2025. It is now read-only.
chore: bump default confirmation-depth 0->8 blocks#285
Merged
Conversation
This is a very important change. Reorgs of 1 block are quite common and can cause a da cert to be submitted to the rollup inbox with a wrong confirmationBlock! It's important to wait a few blocks for the confirmBatch to have landed onchain before submitting the dacert to the batcher inbox.
samlaf
changed the title
bxue-l2
reviewed
Feb 12, 2025
| ```bash | ||
| DISPERSER_ENDPOINT=disperser-holesky.eigenda.xyz:443 | ||
| # Get the request_id from your batcher's proxy logs | ||
| REQUEST_ID=05cb90531098964cc73f0e6b782f52f3b4387e3aed3ef6b89cd9a3c118dd781e-313733393032373134323137353330363738362f302f33332f312f33332fe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 |
Collaborator
Author
There was a problem hiding this comment.
probably... how else would the rollups get it?
Collaborator
There was a problem hiding this comment.
They might have done some local change
bxue-l2
approved these changes
Feb 12, 2025
| RLP_ENCODED_CERT=${OP_ALTDA_COMMITMENT:6} | ||
| cast --from-rlp $RLP_ENCODED_CERT | jq | ||
| ``` | ||
| Unfortunately `cast --from-rlp` doesn't currently support schemas, so you will have to compare the arrays-of-hex-strings output to the [BlobInfo](https://github.com/Layr-Labs/eigenda/blob/f305e046ae3e611e19c15e134571cc2ec83062b4/api/proto/disperser/disperser.proto#L178) schema (note that [CertV1 === BlobInfo](https://github.com/Layr-Labs/eigenda-proxy/blob/97b71bda6e2136a6c0d71be2f7e9642dc840fefc/verify/certificate.go#L31)). |
Collaborator
There was a problem hiding this comment.
shall we create a tool for parsing the Cert?
Collaborator
There was a problem hiding this comment.
I remember Emiliano has the tool, but it isn't difficult to write
Collaborator
Author
There was a problem hiding this comment.
i think we should extend (and rename) kzgpad to have all of these kindsa of tools yes
samlaf
deleted the
chore--change-default-confirmation-depth-to-5-blocks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very important change. Reorgs of 1 block are quite common and can cause a da cert to be submitted to the rollup inbox with a wrong confirmationBlock! It's important to wait a few blocks for the confirmBatch to have landed onchain before submitting the dacert to the batcher inbox.
Also added a troubleshooting guide and added info as to how to troubleshoot the
batch-hash-mismatcherror.Should we set default to finalized instead of 8? That might greatly impact the throughput of rollups, and iirc the longest reorg that ever happened on pos was on goerli and was something like 7 or 8 blocks long.
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers