Change popup LatLng when calling setLatLng on its marker.#272
Closed
tjarratt wants to merge 4 commits intoLeaflet:masterfrom
Closed
Change popup LatLng when calling setLatLng on its marker.#272tjarratt wants to merge 4 commits intoLeaflet:masterfrom
tjarratt wants to merge 4 commits intoLeaflet:masterfrom
Conversation
added 4 commits
August 31, 2011 14:35
It seems like the main use case for marker popups is to bind the location of the marker to the location of the marker. If the marker is moved, via setLatLng, then it stands to reason that the popup should be moved as well.
Dom elements in IE6 through IE8 do not have hasOwnProperty, so a lot of this will break when calling hasOwnProperty on an object that is a dom element.
This breaks horribly in most major versions of IE.
Member
|
Sorry for not responding for so long, finally got to this... Merged manually. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the main use case for marker popups is to bind the location of the marker to the location of the marker. If the marker is moved, via setLatLng, then it stands to reason that the popup should be moved as well.
At least, that's my main use case for using popups. Is there any time when you wouldn't want a popup to move along with a marker when you call setLatLng?