Skip call to this._update() if this._map is null#4280
Merged
mourner merged 1 commit intoLeaflet:masterfrom Mar 1, 2016
errebenito:master
Merged
Skip call to this._update() if this._map is null#4280mourner merged 1 commit intoLeaflet:masterfrom errebenito:master
mourner merged 1 commit intoLeaflet:masterfrom
errebenito:master
Conversation
Returns this instead of this._update() if this._map is not set on addBaseLayer(), addOverlay() and removeLayer().
mourner
added a commit
that referenced
this pull request
Mar 1, 2016
Skip call to this._update() if this._map is null
Member
|
The build passed in master 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
addBaseLayer(),addOverlay()y andremoveLayer()to only returnthis._update()ifthis._mapis not null, and returnthisotherwise. Hopefully solves issue 4274.