Make L.Handler.enable/disable return this by yohanboniface · Pull Request #4708 · Leaflet/Leaflet

yohanboniface · 2016-07-04T20:53:46Z

Those are methods used very often, this can save us a lot of
useless lines.

this.handling.enable().doSomething();

instead of

this.handling.enable()
this.handling.doSomething()

Just like we have for addTo and such.

IvanSanchez · 2016-07-05T07:37:44Z

@yohanboniface Docstrings should reflect the return value too.

Those are methods used very often, this can save us a lot of useless lines.

yohanboniface · 2016-07-05T08:18:32Z

Good catch :)
Fixed!

yohanboniface added the in progress label Jul 4, 2016

yohanboniface force-pushed the handler-return-this branch from fd35680 to 64a1ee6 Compare July 5, 2016 08:18

Make L.Handler.enable/disable return this

64a1ee6

Those are methods used very often, this can save us a lot of useless lines.

IvanSanchez merged commit c263f2d into master Jul 5, 2016

IvanSanchez removed the in progress label Jul 5, 2016

yohanboniface deleted the handler-return-this branch August 8, 2016 10:43

Provide feedback